Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong title in account page bug fix #18

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

mgenovski
Copy link
Contributor

@mgenovski mgenovski commented Feb 25, 2024

Thank you for the great boilerplate!
I was able to find a bug in a page title. This is the bug fix.

Bug:
The title of the Account (Home) page is not updated.

Preconditions:

  1. The user is logged in
  2. The user is at /

Steps to reproduce:

  1. Click on Account
  2. Click on Settings
  3. Click on Home

Expected result:
The title of the Home (/account) page is Account
Actual result:
The title of the Home (/account) page is Settings

@mgenovski mgenovski changed the title Wrong title on account page bug fix Wrong title in account page bug fix Feb 25, 2024
@scosman
Copy link
Contributor

scosman commented Feb 26, 2024

👍 Good catch.

@scosman scosman merged commit f051c7b into CriticalMoments:main Feb 26, 2024
@mgenovski mgenovski deleted the bug-page-title branch February 26, 2024 17:18
Lucho-git pushed a commit to Lucho-git/SKANstarter that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants